Skip to content

Conversation

@CISC
Copy link
Collaborator

@CISC CISC commented Nov 17, 2025

rel #17004

@CISC CISC requested a review from slaren as a code owner November 17, 2025 16:33
@CISC CISC requested a review from ggerganov November 17, 2025 16:34
@github-actions github-actions bot added testing Everything test related Nvidia GPU Issues specific to Nvidia GPUs ggml changes relating to the ggml tensor library for machine learning labels Nov 17, 2025
@CISC
Copy link
Collaborator Author

CISC commented Nov 17, 2025

@jeffbolznv @0cc4m Looks like Vulkan could do with support too (but at least it didn't crash like CUDA did):
https://github.com/ggml-org/llama.cpp/actions/runs/19436977342/job/55610305113?pr=17326#step:3:7370

@jeffbolznv
Copy link
Collaborator

I thought Vulkan already supported this, but I'll check what's going on.

@jeffbolznv
Copy link
Collaborator

@jeffbolznv @0cc4m Looks like Vulkan could do with support too (but at least it didn't crash like CUDA did): https://github.com/ggml-org/llama.cpp/actions/runs/19436977342/job/55610305113?pr=17326#step:3:7370

Fixed in #17328

@CISC
Copy link
Collaborator Author

CISC commented Nov 19, 2025

@slaren gentle ping

Copy link
Collaborator

@JohannesGaessler JohannesGaessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're at it, can you rename the function to ggml_cpy_scalar and either remove the indentation or make it consistent?

@CISC
Copy link
Collaborator Author

CISC commented Nov 21, 2025

While you're at it, can you rename the function to ggml_cpy_scalar and either remove the indentation or make it consistent?

There's a system to the indentation, they are indented to similar calls, but it still looks messy because everything is interleaved, I guess we might as well remove it.

Edit: Looks nicer and much more consistent on their own line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ggml changes relating to the ggml tensor library for machine learning Nvidia GPU Issues specific to Nvidia GPUs testing Everything test related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants