-
Notifications
You must be signed in to change notification settings - Fork 13.8k
cuda : support non-contiguous i32 to i32 copy #17326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@jeffbolznv @0cc4m Looks like Vulkan could do with support too (but at least it didn't crash like CUDA did): |
|
I thought Vulkan already supported this, but I'll check what's going on. |
Fixed in #17328 |
|
@slaren gentle ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While you're at it, can you rename the function to ggml_cpy_scalar and either remove the indentation or make it consistent?
There's a system to the indentation, they are indented to similar calls, but it still looks messy because everything is interleaved, I guess we might as well remove it. Edit: Looks nicer and much more consistent on their own line. |
rel #17004